linux-kernel - Re: [PATCH v4 2/3] mwifiex: parse chip specific gpio from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160218143757.GW9654@rob-hp-laptop>
Date:	Thu, 18 Feb 2016 08:37:57 -0600
From:	Rob Herring <robh@...nel.org>
To:	Amitkumar Karwar <akarwar@...vell.com>
Cc:	linux-bluetooth@...r.kernel.org,
	Nishant Sarmukadam <nishants@...vell.com>,
	wnhuang@...omium.com, devicetree@...r.kernel.org,
	Cathy Luo <cluo@...vell.com>, linux-kernel@...r.kernel.org,
	Xinming Hu <huxm@...vell.com>
Subject: Re: [PATCH v4 2/3] mwifiex: parse chip specific gpio from device tree

On Tue, Feb 16, 2016 at 01:14:38AM -0800, Amitkumar Karwar wrote:
> From: Xinming Hu <huxm@...vell.com>
> 
> This patch parse chip specific gpio parameter from device
> tree. Corresponding binding file is also updated.
> 
> Signed-off-by: Xinming Hu <huxm@...vell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@...vell.com>
> ---
> v4: Renamed "mwifiex,chip-gpio" to "marvell,wakeup-gpios"(Rob Herring/
>     Arnd Bergmann)
> ---
>  .../devicetree/bindings/net/wireless/marvell-sd8xxx.txt          | 6 ++++--

Combine this with the DT change in the next patch.

>  drivers/net/wireless/marvell/mwifiex/sta_cmd.c                   | 9 +++++++++
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt b/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt
> index f7671ae..c337fab 100644
> --- a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt
> @@ -11,7 +11,9 @@ Optional properties:
>    - marvell,caldata* : A series of properties with marvell,caldata prefix,
>    		      represent Calibration data downloaded to the device during
>  		      initialization. This is an array of unsigned values.
> -
> +  - marvell,wakeup-gpios : Chip's wakeup gpio pin number. This needs to be downloaded
> +			to to firmware. Chip notifies wifi wakeup signal to SOC
> +			through this pin.

This is still confusing that it is not a GPIO from the host. I'd suggest 
"marvell,wakeup-pin"