linux-kernel - Re: [PATCH 3/6] ASoC: rockchip: add bindings for rk3399 i2s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160218145954.GI7129@sirena.org.uk>
Date:	Thu, 18 Feb 2016 14:59:54 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Rob Herring <robh@...nel.org>
Cc:	"jianqun.xu" <jay.xu@...k-chips.com>, heiko@...ech.de,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	jwerner@...omium.org, catalin.marinas@....com, will.deacon@....com,
	sboyd@...eaurora.org, linus.walleij@...aro.org,
	sjoerd.simons@...labora.co.uk, huangtao@...k-chips.com,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 3/6] ASoC: rockchip: add bindings for rk3399 i2s

On Thu, Feb 18, 2016 at 08:37:02AM -0600, Rob Herring wrote:
> On Wed, Feb 17, 2016 at 11:03:06AM +0000, Mark Brown wrote:

> > As with the other patch I'd expect to see a matching driver update if
> > only for documentation purposes.

> Why? They match on the prior chip's compatible until there is some 
> difference the driver needs to handle.

That then requires anyone using a compatible string to also know the
full set of other compatible strings that can be used for this device
and that they have to list the others too in the correct order which
isn't something the binding document tells them.  It also feels better
to record in the code how we think we should support the device when we
know it, seems more helpful.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)