lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 11:06:08 -0500 (EST) From: Nicolas Pitre <nicolas.pitre@...aro.org> To: Arnd Bergmann <arnd@...db.de> cc: Russell King <linux@....linux.org.uk>, linux-arm-kernel@...ts.infradead.org, Ard Biesheuvel <ard.biesheuvel@...aro.org>, Jon Medhurst <tixy@...aro.org>, Marc Zyngier <marc.zyngier@....com>, Linus Walleij <linus.walleij@...aro.org>, Maxime Coquelin stm32 <mcoquelin.stm32@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/9] ARM: ARMv7-M uses BE-8, not BE-32 On Thu, 18 Feb 2016, Arnd Bergmann wrote: > When configuring the kernel for big-endian, we set either BE-8 or BE-32 > based on the CPU architecture level. Until linux-4.4, we did not have > any ARMv7-M platform allowing big-endian builds, but now i.MX/Vybrid > is in that category, adn we get a build error because of this: > > arch/arm/kernel/module-plts.c: In function 'get_module_plt': > arch/arm/kernel/module-plts.c:60:46: error: implicit declaration of function '__opcode_to_mem_thumb32' [-Werror=implicit-function-declaration] > > This comes down to picking the wrong default, ARMv7-M uses BE8 > like ARMv7-A does. Changing the default gets the kernel to compile > and presumably works. Was it tested without BE8 when it was submitted upstream? I don't think you can switch this freely on a given hardware platform and expect it to still work. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > arch/arm/mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig > index 55347662e5ed..ff1637365494 100644 > --- a/arch/arm/mm/Kconfig > +++ b/arch/arm/mm/Kconfig > @@ -723,7 +723,7 @@ config CPU_BIG_ENDIAN > config CPU_ENDIAN_BE8 > bool > depends on CPU_BIG_ENDIAN > - default CPU_V6 || CPU_V6K || CPU_V7 > + default CPU_V6 || CPU_V6K || CPU_V7 || CPU_V7M > help > Support for the BE-8 (big-endian) mode on ARMv6 and ARMv7 processors. > > -- > 2.7.0 > >
Powered by blists - more mailing lists