linux-kernel - Re: [PATCH v2 07/14] KVM: x86: remove unnecessary uses of PIT state lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C60785.1080100@redhat.com>
Date:	Thu, 18 Feb 2016 19:03:49 +0100
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Radim Krčmář <rkrcmar@...hat.com>,
	linux-kernel@...r.kernel.org
Cc:	kvm@...r.kernel.org, Yuki Shibuya <shibuya.yk@...s.nec.co.jp>
Subject: Re: [PATCH v2 07/14] KVM: x86: remove unnecessary uses of PIT state
 lock



On 17/02/2016 20:14, Radim Krčmář wrote:
> +	/* All members before "struct mutex lock" are protected by the lock. */

... except reinject, according to the commit message. :)

Paolo

>  	struct kvm_kpit_channel_state channels[3];
>  	u32 flags;
>  	bool is_periodic;
>  	s64 period; 				/* unit: ns */
>  	struct hrtimer timer;
> -	atomic_t pending;			/* accumulated triggered timers */
>  	bool reinject;
> -	struct kvm *kvm;
>  	u32    speaker_data_on;
> +