lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 21:15:33 +0300 From: Ильяс Гасанов <torso.nafi@...il.com> To: Peter Hurley <peter@...leysoftware.com> Cc: "Matwey V. Kornilov" <matwey@....msu.ru>, Greg KH <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.com>, Andy Shevchenko <andy.shevchenko@...il.com>, One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>, linux-kernel <linux-kernel@...r.kernel.org>, linux-serial@...r.kernel.org Subject: Re: [PATCH v8 3/3] tty: 8250_omap: Use software emulated RS485 direction control Hello, 2016-02-18 19:50 GMT+03:00 Peter Hurley <peter@...leysoftware.com>: > No, that's not the way. > > First, there's plenty of driver hooks to properly manage the RTS level > for rs485. For now I'm considering to add the check to uart_dtr_rts in serial_core.c. However, given the access to struct tty_port_operations, I think it's also possible to use a driver-specific hook if it makes more sense. The question is - where exactly does it belong? > Second, how are you running GPIO rts with the omap8250 driver? Through hooking set_mctrl and get_mctrl and using the suggested helpers from serial_mctrl_gpio.c. Though I had to introduce uart_port.get_mctrl to serial_core.h (with set_mctrl already being there) and serial8250_do_get_mctrl to serial_8250.h (same here, serial8250_do_set_mctrl is already there). Regards, Ilyas G.
Powered by blists - more mailing lists