lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 14:09:34 -0500 From: Jes Sorensen <Jes.Sorensen@...hat.com> To: Geliang Tang <geliangtang@....com> Cc: Larry Finger <Larry.Finger@...inger.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Julian Calaby <julian.calaby@...il.com>, linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v5 0/3] staging: rtl8723au: use list_for_each_entry*() and cleaning Geliang Tang <geliangtang@....com> writes: > On Wed, Feb 17, 2016 at 12:28:33PM -0500, Jes Sorensen wrote: >> kbuild test robot <lkp@...el.com> writes: >> > All errors (new ones prefixed by >>): >> > >> > drivers/staging/rtl8723au/core/rtw_recv.c: In function 'rtw_free_recvframe23a_queue': >> >>> drivers/staging/rtl8723au/core/rtw_recv.c:203:2: error: 'plist' undeclared (first use in this function) >> > plist = phead->next; >> > ^ >> >> This doesn't work, you cannot break interim builds. Your patch 2 needs >> to go before patch 1, and you must always check that they compile for >> each patch you apply. >> >> NACK > > Sorry for the trouble caused. I updated my patchs to fix this problem. > > - Geliang > > This patch set uses list_for_each_entry*() instead of > list_for_each*(), removes useless codes, and cleans > whitespaces and blank lines. No worries, I much prefer taking a few rounds to get it right. This set looks good to me. Acked-by: Jes Sorensen <Jes.Sorensen@...hat.com>
Powered by blists - more mailing lists