lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 23:14:59 +0100 From: Paul Bolle <pebolle@...cali.nl> To: Tilman Schmidt <tilman@...p.cc>, netdev@...r.kernel.org Cc: Dmitry Vyukov <dvyukov@...gle.com>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Martin Wilck <Martin.Wilck@...fujitsu.com>, Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, linux-kernel@...r.kernel.org, gigaset307x-common@...ts.sourceforge.net Subject: Re: [PATCH 1/1] ser_gigaset: use container_of() instead of detour On do, 2016-02-18 at 22:42 +0100, Tilman Schmidt wrote: > Acked-by: Tilman Schmidt <tilman@...p.cc> > > Thanks for cleaning up the mess I left behind. That's not how I look at it. Commit 4c5e354a9742 ("ser_gigaset: fix deallocation of platform device structure") provided a plausible fix for the issue we were trying to fix two months ago. If the platform code hadn't been broken when you wrote it - broken for ser_gigaset's corner case, that is - you would have noticed the lifetime rules of driver_data the hard way. (I suspect I might have never noticed if syzkaller hadn't insisted in rubbing my nose in it.) So chances are you would have come up with something similar to this fix would commit 25cad69f21f5 ("base/platform: Fix platform drivers with no probe callback") already have landed. Thanks, Paul Bolle
Powered by blists - more mailing lists