lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 15:47:18 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: "Matwey V. Kornilov" <matwey@....msu.ru> Cc: Andy Shevchenko <andy.shevchenko@...il.com>, Jiri Slaby <jslaby@...e.com>, Peter Hurley <peter@...leysoftware.com>, One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, Ильяс Гасанов <torso.nafi@...il.com> Subject: Re: [PATCH v1] tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init() On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote: > 2016-02-18 23:21 GMT+03:00 Andy Shevchenko <andy.shevchenko@...il.com>: > > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov <matwey@....msu.ru> wrote: > >> serial8250_em485_init() is supposed to be protected with > >> p->port.lock spinlock. > >> This may lead to issues when kmalloc sleeps, so it is better to use > >> GFP_ATOMIC in this spinlocked context. > >> > >> Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250") > >> Reported-by: <torso.nafi@...il.com> > > > > Hmm... Can't we put Cyrillic characters to tags as name of a person? > > I am afraid non-ASCII will break something eventually. I think it > would be better to ask Ilias to put his name in proper latin > transcription here. Why, we accept non-ASCII names all the time, why would we not do so? Please fix up and resend. thansk, greg k-h
Powered by blists - more mailing lists