linux-kernel - Re: [PATCH next] ARM: virt: fix build of hyp-stub

Open Source and information security mailing list archives

Date:	Fri, 19 Feb 2016 10:18:02 +0000
From:	Jean-Philippe Brucker <Jean-Philippe.Brucker@....com>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marc Zyngier <marc.zyngier@....com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH next] ARM: virt: fix build of hyp-stub

Hi Vincent,

On Fri, Feb 19, 2016 at 12:31:17AM +0100, Vincent Stehlé wrote:
> Compile hyp-stub explicitly for arm v7-a. This fixes the following build
> errors:
> 
>   arch/arm/kernel/hyp-stub.S: Assembler messages:
>   arch/arm/kernel/hyp-stub.S:168: Error: selected processor does not support `ubfx r7,r7,#28,#4' in ARM mode
>   arch/arm/kernel/hyp-stub.S:176: Error: selected processor does not support `isb' in ARM mode
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
> Cc: Jean-Philippe Brucker <jean-philippe.brucker@....com>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: Russell King <rmk+kernel@....linux.org.uk>
> ---
> 
> 
> Hi,
> 
> This can be seen with linux next-20160218 and arm e.g. allmodconfig.

Thanks for doing this. I just posted my fix to the patch system, before
seeing yours (it also requires change in boot/compressed/Makefile -
hyp-stub is built twice). See the previous discussion about this issue
here: http://thread.gmane.org/gmane.linux.ports.arm.kernel/479256

Thanks,
Jean-Philippe

> 
> Best regards,
> 
> V.
> 
> 
>  arch/arm/kernel/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
> index 2c5f160..15684c5 100644
> --- a/arch/arm/kernel/Makefile
> +++ b/arch/arm/kernel/Makefile
> @@ -88,6 +88,8 @@ obj-$(CONFIG_DEBUG_LL)	+= debug.o
>  obj-$(CONFIG_EARLY_PRINTK)	+= early_printk.o
>  
>  obj-$(CONFIG_ARM_VIRT_EXT)	+= hyp-stub.o
> +AFLAGS_hyp-stub.o		:=-Wa,-march=armv7-a
> +
>  ifeq ($(CONFIG_ARM_PSCI),y)
>  obj-$(CONFIG_SMP)		+= psci_smp.o
>  endif
> -- 
> 2.7.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives