linux-kernel - Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160219131945.GX2607@odux.rfo.atmel.com>
Date:	Fri, 19 Feb 2016 14:19:45 +0100
From:	Ludovic Desroches <ludovic.desroches@...el.com>
To:	Romain Izard <romain.izard.pro@...il.com>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<devicetree@...r.kernel.org>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux GPIO List <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq
 pinctrl node

On Thu, Feb 18, 2016 at 11:21:06AM +0100, Romain Izard wrote:
> All pinctrl nodes for the Atmel pinctrl controller need to have their
> bias configuration explicitly defined. Otherwise, the pinctrl mapping
> is not valid.
> 
> It works for now as the pinctrl driver proceeds even with invalid
> mappings, but this can become an issue, if the pinctrl driver starts
> to require valid mappings. Additionally, the pin is not protected from
> being remapped later by an other driver.
> 
> There is an external 1kΩ pull-up to 3.3V, so no bias is required on
> the Ethernet PHY's interrupt line.
> 
> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>

Acked-by: Ludovic Desroches <ludovic.desroches@...el.com>

Thanks

> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index e683856c507c..75341eec2dfd 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> @@ -308,6 +308,7 @@
>  
>  				pinctrl_macb0_phy_irq: macb0_phy_irq {
>  					pinmux = <PIN_PC9__GPIO>;
> +					bias-disable;
>  				};
>  
>  				pinctrl_pdmic_default: pdmic_default {
> -- 
> 2.5.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html