linux-kernel - Re: [RFC v2 7/7] kprobes: port to linker table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160219141511.GX19428@n2100.arm.linux.org.uk>
Date:	Fri, 19 Feb 2016 14:15:11 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
	x86@...nel.org, linux-kernel@...r.kernel.org, luto@...capital.net,
	boris.ostrovsky@...cle.com, rusty@...tcorp.com.au,
	david.vrabel@...rix.com, konrad.wilk@...cle.com, mcb30@...e.org,
	jgross@...e.com, ming.lei@...onical.com,
	gregkh@...uxfoundation.org, arnd@...db.de,
	linux-arch@...r.kernel.org, benh@...nel.crashing.org,
	jbaron@...mai.com, ananth@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net,
	masami.hiramatsu.pt@...achi.com, andriy.shevchenko@...ux.intel.com,
	dwmw2@...radead.org, xen-devel@...ts.xensource.com
Subject: Re: [RFC v2 7/7] kprobes: port to linker table

On Fri, Feb 19, 2016 at 05:45:59AM -0800, Luis R. Rodriguez wrote:
> kprobe makes use of two custom sections:
> 
> type       name                  begin                    end
> init.data _kprobe_blacklist __start_kprobe_blacklist	__stop_kprobe_blacklist
> text      .kprobes.text     __kprobes_text_start        __kprobes_text_end
> 
> Port these to the linker table generic solution. This lets
> us remove all the custom kprobe section declarations on the
> linker script.

I don't like this.  You create this "table" thing, which you use for
tables, and then you go and use it for something else - for kprobes
text which is not a table.  The kprobes text section is a section for
text which is not kprobe-able.

So, it seems to be a complete mis-nomer to me.  Maybe you can explain
the rationale here?

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.