linux-kernel - Re: [PATCH] clk: gpio: Really allow an optional clock= DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEG3pNAee6e7nnnCB334zecADV58yfcJ5azUjALHaDP40B_pLQ@mail.gmail.com>
Date:	Fri, 19 Feb 2016 08:18:50 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-clk <linux-clk@...r.kernel.org>,
	"Stephen Boyd <sboyd@...eaurora.org>, Emilio Lopez
	<emilio@...pez.com.ar>, Hans de Goede <hdegoede@...hat.com>, linux-clk
	<linux-clk@...r.kernel.org>, linux-arm-kernel" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH] clk: gpio: Really allow an optional clock= DT property

On Thu, Feb 18, 2016 at 7:12 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
>
> We mis-merged the original patch from Russell here and so the
> patch went almost all the way, except that we still failed to
> probe when there wasn't a clocks property in the DT node. Allow
> that case by making a negative value from
> of_clk_get_parent_count() into "no parents", like the original
> patch did.
>
> Fixes: 7ed88aa2efa5 ("clk: fix clk-gpio.c with optional clock= DT property")
> Cc: Russell King <rmk+kernel@....linux.org.uk>
> Cc: Michael Turquette <mturquette@...libre.com>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Ack.

Regards,
Mike

> ---
>  drivers/clk/clk-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
> index 19fed65587e8..7b09a265d79f 100644
> --- a/drivers/clk/clk-gpio.c
> +++ b/drivers/clk/clk-gpio.c
> @@ -289,7 +289,7 @@ static void __init of_gpio_clk_setup(struct device_node *node,
>
>         num_parents = of_clk_get_parent_count(node);
>         if (num_parents < 0)
> -               return;
> +               num_parents = 0;
>
>         data = kzalloc(sizeof(*data), GFP_KERNEL);
>         if (!data)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>



-- 
Michael Turquette
CEO
BayLibre - At the Heart of Embedded Linux
http://baylibre.com/