linux-kernel - Re: [PATCH] hwmon: (ads1015) Handle negative conversion values correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160219031640.GA8786@roeck-us.net>
Date:	Thu, 18 Feb 2016 19:16:40 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Peter Rosin <peda@...ator.liu.se>
Cc:	Dirk Eibach <eibach@...ys.de>, Peter Rosin <peda@...ntia.se>,
	Jean Delvare <jdelvare@...e.de>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (ads1015) Handle negative conversion values
 correctly

On Fri, Feb 19, 2016 at 12:13:43AM +0100, Peter Rosin wrote:
> Hi!
> 
> Sorry for the noise, but...
> 
> On 2016-02-18 14:07, Peter Rosin wrote:
> > From: Peter Rosin <peda@...ntia.se>
> > 
> > Make the divisor signed as DIV_ROUND_CLOSEST is undefined for negative
> > dividends when the divisor is unsigned.
> > 
> > Signed-off-by: Peter Rosin <peda@...ntia.se>
> 
> ...I forgot to add this to the commit message
> Cc: stable@...r.kernel.org
> 
No problem, I prefer to do that myself anyway.

Patch applied.

Thanks,
Guenter

> I also didn't explicitly mention any example platform where this
> bug causes real problems; it was triggered on ARM (atmel sama5d).
> 
> Cheers,
> Peter
> 
> > ---
> >  drivers/hwmon/ads1015.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hwmon/ads1015.c b/drivers/hwmon/ads1015.c
> > index f155b8380481..2b3105c8aed3 100644
> > --- a/drivers/hwmon/ads1015.c
> > +++ b/drivers/hwmon/ads1015.c
> > @@ -126,7 +126,7 @@ static int ads1015_reg_to_mv(struct i2c_client *client, unsigned int channel,
> >  	struct ads1015_data *data = i2c_get_clientdata(client);
> >  	unsigned int pga = data->channel_data[channel].pga;
> >  	int fullscale = fullscale_table[pga];
> > -	const unsigned mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> > +	const int mask = data->id == ads1115 ? 0x7fff : 0x7ff0;
> >  
> >  	return DIV_ROUND_CLOSEST(reg * fullscale, mask);
> >  }
> >