linux-kernel - Re: [PATCH v13 08/29] tracing: Add lock-free tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160219143810.06d96c89@gandalf.local.home>
Date:	Fri, 19 Feb 2016 14:38:10 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc:	masami.hiramatsu.pt@...achi.com, namhyung@...nel.org,
	josh@...htriplett.org, andi@...stfloor.org,
	mathieu.desnoyers@...icios.com, peterz@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 08/29] tracing: Add lock-free tracing_map

On Thu, 10 Dec 2015 12:50:50 -0600
Tom Zanussi <tom.zanussi@...ux.intel.com> wrote:

> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index e45db6b..48b7329 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -528,6 +528,19 @@ config MMIOTRACE
>  	  See Documentation/trace/mmiotrace.txt.
>  	  If you are not helping to develop drivers, say N.
>  
> +config TRACING_MAP
> +	bool
> +	depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
> +	default n

Default is always n ;-)

> +	help
> +	  tracing_map is a special-purpose lock-free map for tracing,
> +	  separated out as a stand-alone facility in order to allow it
> +	  to be shared between multiple tracers.  It isn't meant to be
> +	  generally used outside of that context, and is normally
> +	  selected by tracers that use it.
> +
> +	  If in doubt, say N.

This doesn't have a prompt. I'm going to nuke both the "If in doubt"
and the "default n" from the patch.

-- Steve

> +
>  config MMIOTRACE_TEST
>  	tristate "Test module for mmiotrace"
>  	depends on MMIOTRACE && m