linux-kernel - Re: [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160219210329.GT25240@wotan.suse.de>
Date:	Fri, 19 Feb 2016 22:03:29 +0100
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:	"Luis R. Rodriguez" <mcgrof@...nel.org>, hpa@...or.com,
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
	linux-kernel@...r.kernel.org, luto@...capital.net,
	rusty@...tcorp.com.au, david.vrabel@...rix.com,
	konrad.wilk@...cle.com, mcb30@...e.org, jgross@...e.com,
	andriy.shevchenko@...ux.intel.com, xen-devel@...ts.xensource.com
Subject: Re: [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h

On Fri, Feb 19, 2016 at 10:14:42AM -0500, Boris Ostrovsky wrote:
> 
> 
> On 02/19/2016 09:15 AM, Luis R. Rodriguez wrote:
> >diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h
> >index 878e4b9940d9..232cff0ff4e3 100644
> >--- a/arch/x86/boot/bitops.h
> >+++ b/arch/x86/boot/bitops.h
> >@@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr)
> >  	asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr));
> >  }
> >+#define BIT(x)	(1 << x)
> 
> Parenthesize x.

I'll just use (1UL << (nr)) then as well to match what
include/linux/bitmap.h uses.

 Luis