linux-kernel - Re: [PATCH] uapi: update install list after nvme.h rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56C7993E.2040907@fb.com>
Date:	Fri, 19 Feb 2016 15:37:50 -0700
From:	Jens Axboe <axboe@...com>
To:	Mario Limonciello <mario_limonciello@...l.com>,
	Jiri Slaby <jslaby@...e.cz>, <linux-kernel@...r.kernel.org>,
	<hch@....de>, <keith.busch@...el.com>, <stable@...r.kernel.org>
CC:	Michal Marek <MMarek@...e.com>,
	Kernel Build Daemon <kbuild@...e.de>,
	"Dominguez, Jared" <Jared_Dominguez@...L.com>
Subject: Re: [PATCH] uapi: update install list after nvme.h rename

On 02/19/2016 03:23 PM, Mario Limonciello wrote:
>
>
> On 01/14/2016 02:26 AM, Jiri Slaby wrote:
>> On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
>>> On 12 Jan 2016 09:45, Jiri Slaby wrote:
>>>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
>>>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of the
>>>>> uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, but
>>>>> the uapi list still refers to nvme.h.  People trying to install
>>>>> the headers hit a failure as the header no longer exists.
>>>>
>>>> Wouldn't reverting the rename be nicer to userspace? So that the
>>>> filename is preserved and anybody who #included nvme.h still can
>>>> do so?
>>
>>> i have no opinion on either route
>>
> Can someone with authority please decide on what to do about this?
> It's wrecking havoc in userspace right now on stuff that needs nvme.h.

The patch is in Linus' tree, and it was marked stable as well. So stable 
will pick it up, when the next 4.4-stable is spun.

-- 
Jens Axboe