linux-kernel - Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2016 20:36:35 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	devel@...verdev.osuosl.org,
	"J . German Rivera" <German.Rivera@...escale.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module

On Thu, Feb 18, 2016 at 03:02:30PM +0100, Thierry Reding wrote:
> On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@...dia.com>
> > 
> > This driver uses functionality (MSI IRQ domain) whose symbols aren't
> > exported, and hence the modular build fails. While arguably there might
> > be reasons to make these symbols available to modules, that change would
> > be fairly involved and the set of exported functions should be carefully
> > auditioned. Fix the build failure for now by marking the driver boolean.
> > 
> > Cc: J. German Rivera <German.Rivera@...escale.com>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Thierry Reding <treding@...dia.com>
> > ---
> >  drivers/staging/fsl-mc/bus/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Sorry for being pushy, but this has had allmodconfig builds broken in
> linux-next for a couple of days now. The driver has been marked BROKEN
> now in linux-next to remedy that, but having proper fixes seems better
> than that.

Sorry for the delay, now merged, thanks.

greg k-h