linux-kernel - Re: [PATCH v6 09/25] perf hists: Basic support of hierarchical report view

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160220231845.GA17925@krava.homerouter.cpe>
Date:	Sun, 21 Feb 2016 00:18:45 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH v6 09/25] perf hists: Basic support of hierarchical
 report view

On Tue, Feb 16, 2016 at 11:08:27PM +0900, Namhyung Kim wrote:

SNIP

> +	int64_t cmp;
> +
> +	while (*p != NULL) {
> +		parent = *p;
> +		iter = rb_entry(parent, struct hist_entry, rb_node_in);
> +
> +		cmp = fmt->collapse(fmt, iter, he);
> +		if (!cmp) {
> +			he_stat__add_stat(&iter->stat, &he->stat);
> +			return iter;
> +		}
> +
> +		if (cmp < 0)
> +			p = &parent->rb_left;
> +		else
> +			p = &parent->rb_right;
> +	}
> +
> +	new = hist_entry__new(he, true);
> +	if (new == NULL)
> +		return NULL;
> +
> +	hists__apply_filters(hists, new);
> +	hists->nr_entries++;
> +
> +	/* save related format for output */
> +	new->fmt = fmt;
> +
> +	/* it's now passed to 'new' */
> +	he->trace_output = NULL;

should you do the same to he->srcline ?

jirka