linux-kernel - Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56C7E5DE.30505@nvidia.com>
Date:	Sat, 20 Feb 2016 09:34:46 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove


On Tuesday 16 February 2016 08:33 PM, Linus Walleij wrote:
> On Mon, Feb 15, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:
>
>> Add device managed APIs devm_gpiochip_add_data() and
>> devm_gpiochip_remove() for the APIs gpiochip_add_data()
>> and gpiochip_remove().
>>
>> This helps in reducing code in error path and sometimes
>> removal of .remove callback for driver unbind.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> I like the looks of this.
>
> One comment: you must also patch
> Documentation/driver-model/devres.txt

Sure,

>
> Will you also follow up with a massive patch set making use of
> this new API? I feel bad about merging an API if it's not used.
>
> Thanks for only supporting this for the new _data() function.
>
>
Yes, I have planned for this to use this new API. This is just for 
getting review whether fine or not to have devm_* APIs so that I can 
make changes on rest of driver to use this new APIs.