linux-kernel - Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456012950.4031.17.camel@perches.com>
Date:	Sat, 20 Feb 2016 16:02:30 -0800
From:	Joe Perches <joe@...ches.com>
To:	Simon Quigley <tsimonq2@...ntu.com>, clm@...com
Cc:	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80
 characters

On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
[]
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
[]
> @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>  	unsigned long ptr;
>  
>  	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> +		ret = btrfs_find_one_extref(fs_root,
> +						inum,
> +						offset,
> +						path,
> +						&extref,
>  					    &offset);

I think this is poor because all the arguments aren't aligned.

It'd be nicer like:

		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
					    &extref, &offset);