linux-kernel - Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456019356.4031.18.camel@perches.com>
Date:	Sat, 20 Feb 2016 17:49:16 -0800
From:	Joe Perches <joe@...ches.com>
To:	Simon Quigley <tsimonq2@...ntu.com>, clm@...com
Cc:	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80

On Sat, 2016-02-20 at 18:57 -0600, Simon Quigley wrote:
> Better?

No, not really.

The alignment should be to the open parenthesis
as I wrote in the first reply.

> On 02/20/2016 06:56 PM, Simon Quigley wrote:
> > checkpatch.pl reported a warning of over 80 characters on line 1833
> > 
> > Adjusted to put &extref and &offset on a different line
> > 
> > Signed-off-by: Simon Quigley <tsimonq2@...ntu.com>
> > ---
> >   fs/btrfs/backref.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> > index f6dac40..956fffa 100644
> > --- a/fs/btrfs/backref.c
> > +++ b/fs/btrfs/backref.c
> > @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum,
> > struct btrfs_root *fs_root,
> >   	unsigned long ptr;
> > 
> >   	while (1) {
> > -		ret = btrfs_find_one_extref(fs_root, inum, offset,
> > path, &extref,
> > -					    &offset);
> > +		ret = btrfs_find_one_extref(fs_root, inum, offset,
> > path,
> > +							&extref,
> > &offset);
> >   		if (ret < 0)
> >   			break;
> >   		if (ret) {
> >