linux-kernel - Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Feb 2016 20:08:30 -0600
From:	Simon Quigley <tsimonq2@...ntu.com>
To:	joe@...ches.com, clm@...com
Cc:	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80
 characters

I apologize, I had my text editor set to a 4 space tab instead of 8 so I 
couldn't see this clearly. That's fixed now, and it won't happen again. 
Is this what you wanted? It seems to line up exactly like you proposed.

On 02/20/2016 08:06 PM, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
>
> Adjusted to put &extref and &offset on a different line
>
> Signed-off-by: Simon Quigley <tsimonq2@...ntu.com>
> ---
>   fs/btrfs/backref.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index f6dac40..81b0863 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -1830,8 +1830,8 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
>   	unsigned long ptr;
>
>   	while (1) {
> -		ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> -					    &offset);
> +		ret = btrfs_find_one_extref(fs_root, inum, offset, path,
> +					    &extref, &offset);
>   		if (ret < 0)
>   			break;
>   		if (ret) {
>