linux-kernel - Re: [PATCH 1/8] tty: n_gsm: fix formatting errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456093820.31061.7.camel@perches.com>
Date:	Sun, 21 Feb 2016 14:30:20 -0800
From:	Joe Perches <joe@...ches.com>
To:	Andrej Krpic <ak77@...de.com>, linux-kernel@...r.kernel.org
Cc:	jslaby@...e.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/8] tty: n_gsm: fix formatting errors

On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote:
> Minor formatting changes to remove errors and reduce number of
> warnings produced by checkpatch.pl script.
[]
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
[]
> @@ -489,7 +490,8 @@ static void gsm_print_packet(const char *hdr, int addr, int cr,
>  		if (!(control & 0x01)) {
>  			pr_cont("I N(S)%d N(R)%d",
>  				(control & 0x0E) >> 1, (control & 0xE0) >> 5);
> -		} else switch (control & 0x0F) {
> +		} else
> +			switch (control & 0x0F) {

Please follow the brace rule for else uses where
if one branch has braces, the other does too.