linux-kernel - Re: [PATCH] PM: declare __tracedata symbols as char[] rather than char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3639816.6c6FK9gNMm@vostro.rjw.lan>
Date:	Sun, 21 Feb 2016 14:45:20 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Eric Biggers <ebiggers3@...il.com>
Cc:	linux-pm@...r.kernel.org, pavel@....cz, len.brown@...el.com,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM: declare __tracedata symbols as char[] rather than char

On Sunday, January 24, 2016 08:08:52 PM Eric Biggers wrote:
> Accessing more than one byte from a symbol declared simply 'char' is undefined
> behavior, as reported by UBSAN:
> 
> 	UBSAN: Undefined behaviour in drivers/base/power/trace.c:178:18
> 	load of address ffffffff8203fc78 with insufficient space
> 	for an object of type 'char'
> 
> Avoid this by declaring the symbols as arrays.
> 
> Signed-off-by: Eric Biggers <ebiggers3@...il.com>

Queued up for 4.6, thanks!

Rafael