linux-kernel - Re: [PATCH] ARM: dts: n900: Use linux input defines instead hardcoded constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Feb 2016 17:28:38 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Benoît Cousson <bcousson@...libre.com>,
	Tony Lindgren <tony@...mide.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, Pavel Machel <pavel@....cz>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Nishanth Menon <nm@...com>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: n900: Use linux input defines instead
 hardcoded constants

Hi,

On Sun, Feb 21, 2016 at 12:06:48PM +0100, Pali Rohár wrote:
> This makes DTS structure more readable.
> 
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> ---
>  arch/arm/boot/dts/omap3-n900.dts |   18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index e0443cd..85c29f3 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -65,45 +65,45 @@
>  		camera_lens_cover {
>  			label = "Camera Lens Cover";
>  			gpios = <&gpio4 14 GPIO_ACTIVE_LOW>; /* 110 */
> -			linux,input-type = <5>; /* EV_SW */
> -			linux,code = <0x09>; /* SW_CAMERA_LENS_COVER */
> +			linux,input-type = <EV_SW>;
> +			linux,code = <SW_CAMERA_LENS_COVER>;
>  			wakeup-source;
>  		};
>  
>  		camera_focus {
>  			label = "Camera Focus";
>  			gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; /* 68 */
> -			linux,code = <0x210>; /* KEY_CAMERA_FOCUS */
> +			linux,code = <KEY_CAMERA_FOCUS>;
>  			wakeup-source;
>  		};
>  
>  		camera_capture {
>  			label = "Camera Capture";
>  			gpios = <&gpio3 5 GPIO_ACTIVE_LOW>; /* 69 */
> -			linux,code = <0xd4>; /* KEY_CAMERA */
> +			linux,code = <KEY_CAMERA>;
>  			wakeup-source;
>  		};
>  
>  		lock_button {
>  			label = "Lock Button";
>  			gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; /* 113 */
> -			linux,code = <0x98>; /* KEY_SCREENLOCK */
> +			linux,code = <KEY_SCREENLOCK>;
>  			wakeup-source;
>  		};
>  
>  		keypad_slide {
>  			label = "Keypad Slide";
>  			gpios = <&gpio3 7 GPIO_ACTIVE_LOW>; /* 71 */
> -			linux,input-type = <5>; /* EV_SW */
> -			linux,code = <0x0a>; /* SW_KEYPAD_SLIDE */
> +			linux,input-type = <EV_SW>;
> +			linux,code = <SW_KEYPAD_SLIDE>;
>  			wakeup-source;
>  		};
>  
>  		proximity_sensor {
>  			label = "Proximity Sensor";
>  			gpios = <&gpio3 25 GPIO_ACTIVE_HIGH>; /* 89 */
> -			linux,input-type = <5>; /* EV_SW */
> -			linux,code = <0x0b>; /* SW_FRONT_PROXIMITY */
> +			linux,input-type = <EV_SW>;
> +			linux,code = <SW_FRONT_PROXIMITY>;
>  		};
>  	};
>  

Acked-By: Sebastian Reichel <sre@...nel.org>

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)