linux-kernel - [PATCH] KVM: remove useless variable in kvm_emulate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 21 Feb 2016 18:35:05 +0800
From:	Long Peng <nimisolo@...il.com>
To:	pbonzini@...hat.com, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Long Peng <nimisolo@...il.com>
Subject: [PATCH] KVM: remove useless variable in kvm_emulate_cpuid()

Originally, this var('function') was used by trace_kvm_cpuid(), but
the trace_kvm_cpuid() has moved into kvm_cpuid() . From then on, this 
var is useless, so we can remove it.

Signed-off-by: Long Peng <nimisolo@...il.com>
---
 arch/x86/kvm/cpuid.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 6525e92..be0ef88 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -836,9 +836,9 @@ EXPORT_SYMBOL_GPL(kvm_cpuid);
 
 void kvm_emulate_cpuid(struct kvm_vcpu *vcpu)
 {
-	u32 function, eax, ebx, ecx, edx;
+	u32 eax, ebx, ecx, edx;
 
-	function = eax = kvm_register_read(vcpu, VCPU_REGS_RAX);
+	eax = kvm_register_read(vcpu, VCPU_REGS_RAX);
 	ecx = kvm_register_read(vcpu, VCPU_REGS_RCX);
 	kvm_cpuid(vcpu, &eax, &ebx, &ecx, &edx);
 	kvm_register_write(vcpu, VCPU_REGS_RAX, eax);
-- 
2.5.0