linux-kernel - Re: [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160221.223656.2213596964617869651.davem@davemloft.net>
Date:	Sun, 21 Feb 2016 22:36:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	santosh.shilimkar@...cle.com
Cc:	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR)
 detection support

From: Santosh Shilimkar <santosh.shilimkar@...cle.com>
Date: Sat, 20 Feb 2016 03:30:02 -0800

> @@ -54,6 +55,8 @@ module_param(rds_ib_mr_8k_pool_size, int, 0444);
>  MODULE_PARM_DESC(rds_ib_mr_8k_pool_size, " Max number of 8K mr per HCA");
>  module_param(rds_ib_retry_count, int, 0444);
>  MODULE_PARM_DESC(rds_ib_retry_count, " Number of hw retries before reporting an error");
> +module_param(prefer_frmr, bool, 0444);
> +MODULE_PARM_DESC(prefer_frmr, "Preferred MR method if both FMR and FRMR supported");

Sorry, you're going to have to create a real run time method to configure
this parameter.

I'm strongly against module parameters.

Please don't go into details about why this might be difficult to do,
I'm totally not interested.  Doing things properly is sometimes not
easy, that's life.