linux-kernel - Re: [patch] sched,rt: __always_inline preemptible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456113785.3706.5.camel@gmail.com>
Date:	Mon, 22 Feb 2016 05:03:05 +0100
From:	Mike Galbraith <umgwanakikbuti@...il.com>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
Cc:	'Sebastian Andrzej Siewior' <bigeasy@...utronix.de>,
	'Thomas Gleixner' <tglx@...utronix.de>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'linux-rt-users' <linux-rt-users@...r.kernel.org>
Subject: Re: [patch]  sched,rt: __always_inline preemptible_lazy()

On Mon, 2016-02-22 at 11:36 +0800, Hillf Danton wrote:
> > 
> > homer: # nm kernel/sched/core.o|grep preemptible_lazy
> > 00000000000000b5 t preemptible_lazy
> > 
> > echo wakeup_rt > current_tracer ==> Welcome to infinity.
> > 
> > Signed-off-bx: Mike Galbraith <umgwanakikbuti@...il.com>
> > ---
> 
> Fat finger?

Yeah, my fingers don't take direction all that well.

> BTW, would you please make a better description of the
> problem this patch is trying to address/fix?

Ok, I thought it was clear what happens.

sched,rt: __always_inline preemptible_lazy()

Functions called within a notrace function must either also be
notrace or be inlined, lest recursion blow the stack.

homer: # nm kernel/sched/core.o|grep preemptible_lazy
00000000000000b5 t preemptible_lazy

echo wakeup_rt > current_tracer ==> Welcome to infinity.

Signed-off-by: Mike Galbraith <umgwanakikbuti@...il.com>
---
 kernel/sched/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche
  * set by a RT task. Oterwise we try to avoid beeing scheduled out as long as
  * preempt_lazy_count counter >0.
  */
-static int preemptible_lazy(void)
+static __always_inline int preemptible_lazy(void)
 {
 	if (test_thread_flag(TIF_NEED_RESCHED))
 		return 1;