linux-kernel - Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160222060230.GA5097@shlinux2.ap.freescale.net>
Date:	Mon, 22 Feb 2016 14:02:30 +0800
From:	Peter Chen <hzpeterchen@...il.com>
To:	Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:	Peter Chen <Peter.Chen@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-usb@...r.kernel.org,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

On Sun, Feb 21, 2016 at 09:32:13PM -0800, Bjorn Andersson wrote:
> On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set
> to be able to do DMA allocations, so use the of_dma_configure() helper
> to populate the dma properties and assign an appropriate dma_ops.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>  drivers/usb/chipidea/core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 7404064b9bbc..047b9d4e67aa 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -62,6 +62,7 @@
>  #include <linux/usb/chipidea.h>
>  #include <linux/usb/of.h>
>  #include <linux/of.h>
> +#include <linux/of_device.h>
>  #include <linux/phy.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/usb/ehci_def.h>
> @@ -834,6 +835,9 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
>  	pdev->dev.dma_parms = dev->dma_parms;
>  	dma_set_coherent_mask(&pdev->dev, dev->coherent_dma_mask);
>  
> +	if (IS_ENABLED(CONFIG_OF) && dev->of_node)
> +		of_dma_configure(&pdev->dev, dev->of_node);
> +
>  	ret = platform_device_add_resources(pdev, res, nres);
>  	if (ret)
>  		goto err;

Just would like to confirm, it will not affect the default behavior
which the "dma-ranges" is not set at those platforms?

-- 

Best Regards,
Peter Chen