linux-kernel - Re: mmc: Add CONFIG_MMC_BLOCK_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160222064551.GA23884@amd>
Date:	Mon, 22 Feb 2016 07:45:52 +0100
From:	Pavel Machek <pavel@....cz>
To:	Mark Salyzyn <salyzyn@...roid.com>
Cc:	linux-kernel@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Luca Porzio <lporzio@...ron.com>,
	yalin wang <yalin.wang2010@...il.com>,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Jon Hunter <jonathanh@...dia.com>,
	Grant Grundler <grundler@...omium.org>,
	Yunpeng Gao <yunpeng.gao@...el.com>,
	Chuanxiao Dong <chuanxiao.dong@...el.com>,
	linux-mmc@...r.kernel.org
Subject: Re: mmc: Add CONFIG_MMC_BLOCK_MAX_SPEED

Hi!

On Thu 2016-02-04 12:29:07, Mark Salyzyn wrote:
> When CONFIG_MMC_BLOCK_MAX_SPEED is enabled, Expose max_read_speed,
> max_write_speed and cache_size controls to simulate a slow eMMC device.
> The boot default values for each respectively are
> CONFIG_MMC_BLOCK_MAX_READ_SPEED, CONFIG_MMC_BLOCK_MAX_WRITE_SPEED and
> CONFIG_MMC_BLOCK_CACHE_SIZE respectively; and if not defined are
> 0 (off), 0, (off) and 4 MB also respectively.

Extra , after 0.

Dunno. At minimum, I'd call the option something like
"MMC_DEBUG_MAX_SPEED" and the speeds should be really controlled via
/sys or something...

...and ... is there reason to limit it to mmc devices? Making
harddrive slow would make it useful for testing, too...

...and you have the /sys interface. Drop the config options?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html