linux-kernel - Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456102461.2386.6.camel@gmail.com>
Date:	Mon, 22 Feb 2016 03:54:21 +0300
From:	Sergei Ianovich <ynvich@...il.com>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Francois Romieu <romieu@...zoreil.com>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	"David S. Miller" <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource

On Sat, 2016-02-20 at 21:45 +0100, Robert Jarzmik wrote:
> The dm9000 driver doesn't work in at least one device-tree
> configuration, spitting an error message on irq resource :
> [    1.062495] dm9000 8000000.ethernet: insufficient resources
> [    1.068439] dm9000 8000000.ethernet: not found (-2).
> [    1.073451] dm9000: probe of 8000000.ethernet failed with error -2
> 
> The reason behind is that the interrupt might be provided by a gpio
> controller, not probed when dm9000 is probed, and needing the probe
> deferral mechanism to apply.
> 
> Currently, the interrupt is directly taken from resources. This patch
> changes this to use the more generic platform_get_irq(), which
> handles
> the deferral.
> 
> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
> IRQ flags from resources"), the interrupt trigger flags are honored
> in
> platform_get_irq(), so remove the needless code in dm9000.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> Acked-by: Marcel Ziswiler <marcel@...wiler.com>
> Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 

Tested-by: Sergei Ianovich <ynvich@...il.com>

I've hit the original bug too. This patch fixes the *regression*. It
may be worth adding a note about this.

-- 
Sergei Ianovich <ynvich@...il.com>