linux-kernel - [PATCH] drivers/misc/ad525x_dpot: AD5274 fix RDAC read back errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1456132824-28591-1-git-send-email-michael.hennerich@analog.com>
Date:	Mon, 22 Feb 2016 10:20:24 +0100
From:	<michael.hennerich@...log.com>
To:	<arnd@...db.de>, <gregkh@...uxfoundation.org>
CC:	<linux-kernel@...r.kernel.org>,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: [PATCH] drivers/misc/ad525x_dpot: AD5274 fix RDAC read back errors

From: Michael Hennerich <michael.hennerich@...log.com>

Fix RDAC read back errors caused by a typo. Value must shift by 2.

Fixes: a4bd394956f2 ("drivers/misc/ad525x_dpot.c: new features")
Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
---
 drivers/misc/ad525x_dpot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
index e9bbc7b..51e3ec2 100644
--- a/drivers/misc/ad525x_dpot.c
+++ b/drivers/misc/ad525x_dpot.c
@@ -216,7 +216,7 @@ static s32 dpot_read_i2c(struct dpot_data *dpot, u8 reg)
 			 */
 			value = swab16(value);
 
-			if (dpot->uid == DPOT_UID(AD5271_ID))
+			if (dpot->uid == DPOT_UID(AD5274_ID))
 				value = value >> 2;
 		return value;
 	default:
-- 
1.9.1