| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Feb 2016 09:52:05 +0000 From: Will Deacon <will.deacon@....com> To: "Shi, Yang" <yang.shi@...aro.org> Cc: catalin.marinas@....com, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linaro-kernel@...ts.linaro.org Subject: Re: [PATCH] arm64: remove redundant preempt.h On Fri, Feb 19, 2016 at 04:07:02PM -0800, Shi, Yang wrote: > Any comment on this one? I don't really see the point in it, to be honest. Relying on implicit #includes is usually a bad idea, there are other files in the kernel including both of these headers and there's not actually a problem to fix as far as I can tell. Will > On 2/12/2016 9:56 AM, Yang Shi wrote: > >preempt.h has been included by sched.h, so it is not necessary to include > >both, just keep sched.h. > > > >Signed-off-by: Yang Shi <yang.shi@...aro.org> > >--- > >Happened to find this when checking preempt.h include for another patch review. > >Build test is passed with and without CONFIG_PREEMPT enabled. > > > > arch/arm64/kernel/cpuinfo.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > >index 212ae63..e2b37ff 100644 > >--- a/arch/arm64/kernel/cpuinfo.c > >+++ b/arch/arm64/kernel/cpuinfo.c > >@@ -25,7 +25,6 @@ > > #include <linux/init.h> > > #include <linux/kernel.h> > > #include <linux/personality.h> > >-#include <linux/preempt.h> > > #include <linux/printk.h> > > #include <linux/seq_file.h> > > #include <linux/sched.h> > > >
Powered by blists - more mailing lists