linux-kernel - [PATCH 0/8] Remove CURRENT_TIME and CURRENT_TIME_SEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Feb 2016 07:17:46 -0800
From:	Deepa Dinamani <deepa.kernel@...il.com>
To:	linux-fsdevel@...r.kernel.org, y2038@...ts.linaro.org
Cc:	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: [PATCH 0/8] Remove CURRENT_TIME and CURRENT_TIME_SEC - PART 2

Introduction

This patch series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC
macros.

The idea for the series evolved from my discussions with Arnd Bergmann.

This was originally part of the RFC series[2]:
https://lkml.org/lkml/2016/1/7/20 (under discussion).

Dave Chinner suggested moving bug fixes out of the feature series to keep the
original series simple.

There are 354 occurrences of the the above macros in the kernel.
The series will be divided into 4 or 5 parts to keep the parts manageable
and so that each part could be reviewed and merged independently.
This is part 2 of the series.

Motivation

The macros: CURRENT_TIME and CURRENT_TIME_SEC are primarily used for
filesystem timestamps.
But, they are not accurate as they do not perform clamping according to
filesystem timestamps ranges, nor do they truncate the nanoseconds value
to the granularity as required by the filesystem.

The series is also viewed as an ancillary to another upcoming series[2]
that attempts to transition file system timestamps to use 64 bit time to
make these y2038 safe.

There will also be another series[3] to add range checks and clamping to
filesystem time functions that are meant to substitute the above macros.

Solution

CURRENT_TIME macro has an equivalent function:

struct timespec current_fs_time(struct super_block *sb)

These will be the changes to the above function:
1. Function will return the type y2038 safe timespec64 in [2].
2. Function will use y2038 safe 64 bit functions in [2].
3. Function will be extended to perform range checks in [3].

A new function will be added to substitute for CURRENT_TIME_SEC macro
in the current series:

struct timespec current_fs_time_sec(struct super_block *sb)

These will be the changes to the above function:
1. Function will return the type y2038 safe timespec64 in [2].
2. Function will use y2038 safe 64 bit functions in [2].
3. Function will be extended to perform range checks in [3].

Any use of these macros outside of filesystem timestamps will
be replaced by function calls to appropriate time functions.

Deepa Dinamani (8):
  fs: debugfs: Replace CURRENT_TIME by current_fs_time()
  fs: logfs: Replace CURRENT_TIME by current_fs_time()
  fs: devpts: Replace CURRENT_TIME by current_fs_time()
  fs: configfs: Replace CURRENT_TIME by current_fs_time()
  fs: proc: Replace CURRENT_TIME by current_fs_time()
  fs: ramfs: Replace CURRENT_TIME by current_fs_time()
  fs: kernfs: Replace CURRENT_TIME by current_fs_time()
  net: sunrpc: Replace CURRENT_TIME by current_fs_time()

 fs/configfs/inode.c   |  8 +++++---
 fs/debugfs/inode.c    |  3 ++-
 fs/devpts/inode.c     |  9 ++++++---
 fs/kernfs/dir.c       |  8 +++++---
 fs/kernfs/inode.c     | 15 ++++++++++-----
 fs/logfs/dir.c        | 11 +++++++----
 fs/logfs/file.c       |  2 +-
 fs/logfs/inode.c      |  3 +--
 fs/logfs/readwrite.c  |  7 ++++---
 fs/proc/base.c        |  3 ++-
 fs/proc/inode.c       |  6 ++++--
 fs/proc/proc_sysctl.c |  3 ++-
 fs/proc/self.c        |  3 ++-
 fs/proc/thread_self.c |  3 ++-
 fs/ramfs/inode.c      | 13 ++++++++-----
 net/sunrpc/rpc_pipe.c |  4 +++-
 16 files changed, 64 insertions(+), 37 deletions(-)

-- 
1.9.1