linux-kernel - Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CB2382.9090709@xilinx.com>
Date:	Mon, 22 Feb 2016 16:04:34 +0100
From:	Michal Simek <michal.simek@...inx.com>
To:	Jean Delvare <jdelvare@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
CC:	Alan Tull <atull@...nsource.altera.com>,
	Moritz Fischer <moritz.fischer@...us.com>,
	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>
Subject: Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver

On 22.2.2016 14:42, Jean Delvare wrote:
> The Zynq FPGA manager driver serves no purpose on other architectures
> so hide it unless build-testing.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Alan Tull <atull@...nsource.altera.com>
> Cc: Moritz Fischer <moritz.fischer@...us.com>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
> ---
> Michal, Sören, I'm not sure if the driver is needed on ARCH_ZYNQMP too?
> 
>  drivers/fpga/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-4.5-rc5.orig/drivers/fpga/Kconfig	2016-01-11 00:01:32.000000000 +0100
> +++ linux-4.5-rc5/drivers/fpga/Kconfig	2016-02-22 14:11:33.142068843 +0100
> @@ -21,6 +21,7 @@ config FPGA_MGR_SOCFPGA
>  
>  config FPGA_MGR_ZYNQ_FPGA
>  	tristate "Xilinx Zynq FPGA"
> +	depends on ARCH_ZYNQ || COMPILE_TEST
>  	help
>  	  FPGA manager driver support for Xilinx Zynq FPGAs.
>  

This driver is zynq specific. ZynqMP will have different driver.
I have no problem to limit this driver just for Zynq.
Currently I am not aware about other usage without changes in the driver.

Thanks,
Michal