linux-kernel - Re: [PATCH v6 0/2] Add initial support for RPM clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CB2966.5060403@linaro.org>
Date:	Mon, 22 Feb 2016 17:29:42 +0200
From:	Georgi Djakov <georgi.djakov@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	mturquette@...libre.com, linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v6 0/2] Add initial support for RPM clocks

On 02/12/2016 02:37 AM, Stephen Boyd wrote:
> On 12/15, Georgi Djakov wrote:
>>
>>  .../devicetree/bindings/clock/qcom,rpmcc.txt       |   37 ++
>>  drivers/clk/qcom/Kconfig                           |   29 ++
>>  drivers/clk/qcom/Makefile                          |    2 +
>>  drivers/clk/qcom/clk-rpm.c                         |  290 +++++++++++++
>>  drivers/clk/qcom/clk-rpm.h                         |   71 ++++
> 
> Do we need this header file?
> 
>>  drivers/clk/qcom/clk-smd-rpm.c                     |  433 ++++++++++++++++++++
>>  drivers/clk/qcom/clk-smd-rpm.h                     |  142 +++++++
> 
> And this one too?
> 
> From what I can tell they're only going to be included by the
> clk-rpm and clk-smd-rpm C files. We can also avoid exporting the
> RPM ops then if we're going to make the C files into full blown
> platform drivers.
> 

Of course, good idea. Fixed it and will resubmit shortly.

Thanks,
Georgi