linux-kernel - Re: [PATCH 1/1] of/overlay: of overlay callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <6F671B0F-4F94-47F0-9CA2-04E6F905F20A@konsulko.com>
Date:	Mon, 22 Feb 2016 17:38:19 +0200
From:	Pantelis Antoniou <pantelis.antoniou@...sulko.com>
To:	Rob Herring <robh@...nel.org>
Cc:	Alan Tull <atull@...nsource.altera.com>,
	Frank Rowand <frowand.list@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Devicetree List <devicetree@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Moritz Fischer <moritz.fischer@...us.com>,
	Alan Tull <delicious.quinoa@...il.com>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>
Subject: Re: [PATCH 1/1] of/overlay: of overlay callbacks

Hi Rob,

> On Feb 22, 2016, at 04:55 , Rob Herring <robh@...nel.org> wrote:
> 
> On Wed, Feb 17, 2016 at 11:41:25AM -0600, Alan Tull wrote:
>> Add overlay callback functionality.
>> 
>> When DT overlays are being added, some drivers/subsystems
>> will want to know about the changes before they go into the
>> live tree.  Similarly there is a need for post-remove
>> callbacks.
>> 
>> Each handler is registered with a of_device_id.  When
>> an overlay target matches a handler's id, the handler
>> gets called.
>> 
>> The following 4 cases are handled: pre-apply, post-apply,
>> pre-remove, and post-remove.
> 
> So I know I suggested maybe not using notifiers, but this ends up just 
> looking like notifiers, so we might as well use them unless we somehow 
> change the flow. You would just need to add pre-apply and pre-remove 
> in of_attach_node and of_detach_node, right?
> 


I agree those look just like notifiers. We could just update the notifier
logic to handle this case.

Am I missing something else?


> Rob

Regards

— Pantelis