linux-kernel - Re: [alsa-devel] [PATCH v2] ASoC: wm9713: fix regmap free path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 22 Feb 2016 11:53:51 +0900
From:	Mark Brown <broonie@...nel.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm9713: fix regmap free path

On Sun, Feb 21, 2016 at 11:12:51AM +0100, Lars-Peter Clausen wrote:
> On 02/20/2016 08:44 PM, Robert Jarzmik wrote:

> > Fix this by removing the doubled regmap free.

> The correct fix is to use the non devm variant of regmap_init_ac97() in this
> case. Device managed functions should only be used from inside a struct
> device probe function.

Gah, didn't notice that we allocate in the non-default probe function :/
Dropped.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)