linux-kernel - Re: [PATCH 11/61] gpio: bcm-kona: Use devm_gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67faee9e-e234-fc60-5465-3193bed4a7c3@broadcom.com>
Date:	Mon, 22 Feb 2016 09:17:13 -0800
From:	Ray Jui <ray.jui@...adcom.com>
To:	Laxman Dewangan <ldewangan@...dia.com>, linus.walleij@...aro.org,
	gnurou@...il.com, michael.hennerich@...log.com, corbet@....net,
	albeu@...e.fr, rjui@...adcom.com, shc_work@...l.ru,
	support.opensource@...semi.com, swarren@...dotorg.org,
	thierry.reding@...il.com
Cc:	bjorn.andersson@...ymobile.com, a.kesavan@...sung.com,
	gregkh@...uxfoundation.org, catalin.marinas@....com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, patches@...nsource.wolfsonmicro.com,
	bcm-kernel-feedback-list@...adcom.com,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 11/61] gpio: bcm-kona: Use devm_gpiochip_add_data() for
 gpio registration



On 2/22/2016 6:08 AM, Laxman Dewangan wrote:
> Use devm_gpiochip_add_data() for GPIO registration.
>
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Cc: Ray Jui <rjui@...adcom.com>
> ---
>  drivers/gpio/gpio-bcm-kona.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
> index b6c5abe..2fd38d5 100644
> --- a/drivers/gpio/gpio-bcm-kona.c
> +++ b/drivers/gpio/gpio-bcm-kona.c
> @@ -630,7 +630,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev)
>
>  	bcm_kona_gpio_reset(kona_gpio);
>
> -	ret = gpiochip_add_data(chip, kona_gpio);
> +	ret = devm_gpiochip_add_data(dev, chip, kona_gpio);
>  	if (ret < 0) {
>  		dev_err(dev, "Couldn't add GPIO chip -- %d\n", ret);
>  		goto err_irq_domain;
>

Acked-by: Ray Jui <ray.jui@...adcom.com>

Thanks!