[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56CCE510.1010906@amd.com>
Date: Tue, 23 Feb 2016 17:02:40 -0600
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To: Borislav Petkov <bp@...en8.de>
CC: <tony.luck@...el.com>, <hpa@...or.com>, <mingo@...hat.com>,
<tglx@...utronix.de>, <dougthompson@...ssion.com>,
<mchehab@....samsung.com>, <x86@...nel.org>,
<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<ashok.raj@...el.com>, <gong.chen@...ux.intel.com>,
<len.brown@...el.com>, <peterz@...radead.org>,
<ak@...ux.intel.com>, <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH 3/4] x86/mce: Clarify comments regarding deferred error
On 2/23/16 6:11 AM, Borislav Petkov wrote:
> On Tue, Feb 16, 2016 at 03:45:10PM -0600, Aravind Gopalakrishnan wrote:
>> /* AMD-specific bits */
>> -#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare an uncorrected error */
>> +#define MCI_STATUS_DEFERRED (1ULL<<44) /* declare a deferred error */
> /* uncorrected error, deferred exception */
>
> sounds better to me.
Hmm. Well, Deferred error is a separate class of error by itself.
It's neither Corrected in HW nor is it Uncorrected like a MCE.
If you feel "Uncorrected error, deferred error exception" won;t be
confusing, that's OK with me.
>
> For the future, such cleanups/fixes should always go first in the patch
> set.
>
Ok, I'll retain the order this time for V2 patchset as well.
But noted for future.
Thanks,
-Aravind.
Powered by blists - more mailing lists