linux-kernel - Re: [PATCH v4] spi: master driver to enable RTC on ICPDAS LP-8841

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Feb 2016 17:28:21 -0600
From:	Rob Herring <robh@...nel.org>
To:	Sergei Ianovich <ynvich@...il.com>
Cc:	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>,
	"open list:SPI SUBSYSTEM" <linux-spi@...r.kernel.org>
Subject: Re: [PATCH v4] spi: master driver to enable RTC on ICPDAS LP-8841

On Tue, Feb 23, 2016 at 01:44:28PM +0300, Sergei Ianovich wrote:
> ICP DAS LP-8841 contains a DS-1302 RTC. This driver provides an SPI
> master which makes the RTC usable. The driver is not supposed to work
> with anything else.
> 
> The driver uses the standard MicroWire half-duplex transfer timing.
> Master output is set on low clock and sensed by the RTC on the rising
> edge. Master input is set by the RTC on the trailing edge and is sensed
> by the master on low clock.
> 
> Signed-off-by: Sergei Ianovich <ynvich@...il.com>
> CC: Mark Brown <broonie@...nel.org>
> CC: Rob Herring <robh@...nel.org>
> 
>    v3..v4
>    fix Mark Brown review comments
>    * fix dependencies in Kconfig
> 
>    fix Rob Herring review comments
>    * rewrite binding description
>    * change binding and doc file names
>    * fix typo
> 
>    v2..v3 to fix Mark Brown review comments
>    * drop dependencies in Kconfig
>    * use #ifdef CONFIG_OF to allow build without DT
>    * drop empty driver->remove
> 
>    v1..v2 to fix Mark Brown review comments
>    * drop ifdef around MODULE_NAME
>    * use usleep_range directly
>    * drop empty master->cleanup
> ---
>  .../bindings/spi/icpdas-lp8841-spi-rtc.txt         |  54 +++++

Acked-by: Rob Herring <robh@...nel.org>