linux-kernel - Re: [PATCH] Staging: comedi: mite: added spaces around

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1456187828.4139.3.camel@perches.com>
Date:	Mon, 22 Feb 2016 16:37:08 -0800
From:	Joe Perches <joe@...ches.com>
To:	Philippe Loctaux <phil@...lippeloctaux.com>,
	gregkh@...uxfoundation.org
Cc:	abbotti@....co.uk, hsweeten@...ionengravers.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and *

On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote:
> Added spaces around | and *, fixing 2 checkpatch checks.
[]
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
[]
> @@ -51,7 +51,7 @@
>  
>  #include "mite.h"
>  
> -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
> +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))

It'd be nice to remove superfluous parentheses here too

+#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)