linux-kernel - [PATCH 06/10] mtip32xx: Fix for rmmod crash when drive is in FTL rebuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <460b47ab-a87d-d326-8bb1-e5a144a39d3e@micron.com>
Date:	Mon, 22 Feb 2016 21:01:37 -0800
From:	Asai Thambi SP <asamymuthupa@...ron.com>
To:	Jens Axboe <axboe@...nel.dk>
CC:	<linux-kernel@...r.kernel.org>,
	Sam Bradshaw <sbradshaw@...ron.com>,
	Selvan Mani <smani@...ron.com>,
	Rajesh Kumar Sambandam <rsambandam@...ron.com>,
	Vignesh Gunasekaran <vgunasekaran@...ron.com>
Subject: [PATCH 06/10] mtip32xx: Fix for rmmod crash when drive is in FTL
 rebuild

When FTL rebuild is in progress, alloc_disk() initializes the disk
but device node will be created by add_disk() only after successful
completion of FTL rebuild. So, skip deletion of device node in
removal path when FTL rebuild is in progress.

Signed-off-by: Selvan Mani <smani@...ron.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@...ron.com>
---
 drivers/block/mtip32xx/mtip32xx.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index ba832a8..7ad3b90 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3037,10 +3037,8 @@ restart_eh:
         }
 
         if (test_bit(MTIP_PF_REBUILD_BIT, &port->flags)) {
-            if (mtip_ftl_rebuild_poll(dd) < 0)
-                set_bit(MTIP_DDF_REBUILD_FAILED_BIT,
-                            &dd->dd_flag);
-            clear_bit(MTIP_PF_REBUILD_BIT, &port->flags);
+            if (mtip_ftl_rebuild_poll(dd) == 0)
+                clear_bit(MTIP_PF_REBUILD_BIT, &port->flags);
         }
     }
 
@@ -3920,7 +3918,6 @@ static int mtip_block_initialize(struct driver_data *dd)
 
     mtip_hw_debugfs_init(dd);
 
-skip_create_disk:
     memset(&dd->tags, 0, sizeof(dd->tags));
     dd->tags.ops = &mtip_mq_ops;
     dd->tags.nr_hw_queues = 1;
@@ -3950,6 +3947,7 @@ skip_create_disk:
     dd->disk->queue        = dd->queue;
     dd->queue->queuedata    = dd;
 
+skip_create_disk:
     /* Initialize the protocol layer. */
     wait_for_rebuild = mtip_hw_get_identify(dd);
     if (wait_for_rebuild < 0) {
@@ -4112,7 +4110,8 @@ static int mtip_block_remove(struct driver_data *dd)
         dd->bdev = NULL;
     }
     if (dd->disk) {
-        del_gendisk(dd->disk);
+        if (test_bit(MTIP_DDF_INIT_DONE_BIT, &dd->dd_flag))
+            del_gendisk(dd->disk);
         if (dd->disk->queue) {
             blk_cleanup_queue(dd->queue);
             blk_mq_free_tag_set(&dd->tags);
@@ -4153,7 +4152,8 @@ static int mtip_block_shutdown(struct driver_data *dd)
         dev_info(&dd->pdev->dev,
             "Shutting down %s ...\n", dd->disk->disk_name);
 
-        del_gendisk(dd->disk);
+        if (test_bit(MTIP_DDF_INIT_DONE_BIT, &dd->dd_flag))
+            del_gendisk(dd->disk);
         if (dd->disk->queue) {
             blk_cleanup_queue(dd->queue);
             blk_mq_free_tag_set(&dd->tags);
-- 
1.7.1