linux-kernel - RE: [PATCH] ARM: at91: sama5/dts: move hsmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A243641D642838E@penmbx01>
Date:	Tue, 23 Feb 2016 06:02:55 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Brown <broonie@...nel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"Kumar Gala" <galak@...eaurora.org>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Russell King <linux@....linux.org.uk>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Wu, Josh" <Josh.wu@...el.com>, Josh Wu <rainyfeeling@...look.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Subject: RE: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node



> -----Original Message-----
> From: Ferre, Nicolas
> Sent: 2016年2月22日 20:58
> To: Yang, Wenyou <Wenyou.Yang@...el.com>; Rob Herring
> <robh+dt@...nel.org>; Pawel Moll <pawel.moll@....com>; Mark Brown
> <broonie@...nel.org>; Ian Campbell <ijc+devicetree@...lion.org.uk>; Kumar
> Gala <galak@...eaurora.org>; Alexandre Belloni <alexandre.belloni@...e-
> electrons.com>; Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>;
> Russell King <linux@....linux.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> devicetree@...r.kernel.org; Wu, Josh <Josh.wu@...el.com>; Josh Wu
> <rainyfeeling@...look.com>; Alexandre Belloni <alexandre.belloni@...e-
> electrons.com>
> Subject: Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
> 
> Le 17/02/2016 06:42, Wenyou Yang a écrit :
> > From: Josh Wu <josh.wu@...el.com>
> >
> > In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> > part of HSMC. So move out hsmc_clk from nfc node to nand node.
> >
> > Signed-off-by: Josh Wu <rainyfeeling@...look.com>
> > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> 
> I'm not against this change, but beware, it must be applied in synchronization with
> the patch just posted "[PATCH] mtd: atmel_nand:
> move the hsmc_clk from nfc node to nand node"

Okay, revert the mail address to the original one, keep it consistent.

And add this address to CC. 

> 
> Bye,
> 
> 
> > ---
> >
> >  arch/arm/boot/dts/sama5d3.dtsi |    2 +-
> >  arch/arm/boot/dts/sama5d4.dtsi |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sama5d3.dtsi
> > b/arch/arm/boot/dts/sama5d3.dtsi index a532791..a242d27 100644
> > --- a/arch/arm/boot/dts/sama5d3.dtsi
> > +++ b/arch/arm/boot/dts/sama5d3.dtsi
> > @@ -1474,6 +1474,7 @@
> >  			atmel,nand-has-dma;
> >  			pinctrl-names = "default";
> >  			pinctrl-0 = <&pinctrl_nand0_ale_cle>;
> > +			clocks = <&hsmc_clk>;
> >  			atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
> >  			status = "disabled";
> >
> > @@ -1486,7 +1487,6 @@
> >  					0xffffc000 0x00000070	/* NFC HSMC
> regs */
> >  					0x00200000 0x00100000	/* NFC
> SRAM banks */
> >  					>;
> > -				clocks = <&hsmc_clk>;
> >  			};
> >  		};
> >  	};
> > diff --git a/arch/arm/boot/dts/sama5d4.dtsi
> > b/arch/arm/boot/dts/sama5d4.dtsi index b8032bc..1499b33 100644
> > --- a/arch/arm/boot/dts/sama5d4.dtsi
> > +++ b/arch/arm/boot/dts/sama5d4.dtsi
> > @@ -295,6 +295,7 @@
> >  			atmel,nand-has-dma;
> >  			pinctrl-names = "default";
> >  			pinctrl-0 = <&pinctrl_nand>;
> > +			clocks = <&hsmc_clk>;
> >  			status = "disabled";
> >
> >  			nfc@...00000 {
> > @@ -306,7 +307,6 @@
> >  					0xfc05c000 0x00000070	/* NFC
> HSMC regs */
> >  					0x00100000 0x00100000	/* NFC
> SRAM banks */
> >                                           >;
> > -				clocks = <&hsmc_clk>;
> >  				atmel,write-by-sram;
> >  			};
> >  		};
> >
> 
> 
> --
> Nicolas Ferre


Best Regards,
Wenyou Yang