linux-kernel - Re: [Xen-devel] [PATCH v3 10/11] x86/rtc: replace paravirt rtc check with x86 specific solution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56CC491C.8080505@citrix.com>
Date:	Tue, 23 Feb 2016 11:57:16 +0000
From:	David Vrabel <david.vrabel@...rix.com>
To:	"Luis R. Rodriguez" <mcgrof@...nel.org>, <bp@...en8.de>,
	<hpa@...or.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<rusty@...tcorp.com.au>
CC:	<xen-devel@...ts.xensource.com>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, <luto@...capital.net>,
	<lguest@...ts.ozlabs.org>, <david.vrabel@...rix.com>,
	<boris.ostrovsky@...cle.com>
Subject: Re: [Xen-devel] [PATCH v3 10/11] x86/rtc: replace paravirt rtc check
 with x86 specific solution

On 23/02/16 07:24, Luis R. Rodriguez wrote:
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
[...]
> @@ -1526,8 +1525,6 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  
>  	/* Install Xen paravirt ops */
>  	pv_info = xen_info;
> -	if (xen_initial_domain())
> -		pv_info.features |= PV_SUPPORTED_RTC;
>  	pv_init_ops = xen_init_ops;
>  	if (!xen_pvh_domain()) {
>  		pv_cpu_ops = xen_cpu_ops;
> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> index a0a4e554c6f1..fbfcb01015f0 100644
> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -446,8 +446,10 @@ void __init xen_init_time_ops(void)
>  	x86_platform.calibrate_tsc = xen_tsc_khz;
>  	x86_platform.get_wallclock = xen_get_wallclock;
>  	/* Dom0 uses the native method to set the hardware RTC. */
> -	if (!xen_initial_domain())
> +	if (!xen_initial_domain()) {
> +		x86_init.platform_flags |= X86_PLATFORM_NO_RTC;
>  		x86_platform.set_wallclock = xen_set_wallclock;
> +	}
>  }

Is this an early enough point to set this flag?

David