[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <56CC69F6.2000305@redhat.com>
Date: Tue, 23 Feb 2016 15:17:26 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Xiao Guangrong <guangrong.xiao@...ux.intel.com>
Cc: gleb@...nel.org, mtosatti@...hat.com, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org, kai.huang@...ux.intel.com,
jike.song@...el.com
Subject: Re: [PATCH v3 11/11] KVM: MMU: apply page track notifier
On 23/02/2016 05:40, Xiao Guangrong wrote:
>>>
>>> @@ -7878,6 +7877,7 @@ void kvm_arch_destroy_vm(struct kvm *kvm)
>>> kfree(kvm->arch.vioapic);
>>> kvm_free_vcpus(kvm);
>>> kfree(rcu_dereference_check(kvm->arch.apic_map, 1));
>>> + kvm_mmu_uninit_vm(kvm);
>>
>> This function is not necessary, since the VM is disappearing anyway and
>> the page tracker is not going to be called.
>
> I think it is still necessary, as we are using srcu to protect the
> notifier, so
> we should wait all the callers of notifier callbacks gone, i.e,
> synchronize_srcu() is needed anyway.
You're right.
Paolo
Powered by blists - more mailing lists