linux-kernel - Re: [PATCH v3] mptbase: fixup error handling paths in mpt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160223142914.GB7128@c203.arch.suse.de>
Date:	Tue, 23 Feb 2016 15:29:14 +0100
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	"Ewan D. Milne" <emilne@...hat.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	wuninsu@...il.com, thenzl@...hat.com,
	sreekanth.reddy@...gotech.com, MPT-FusionLinux.pdl@...gotech.com,
	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu,
	changwoo@...ech.edu
Subject: Re: [PATCH v3] mptbase: fixup error handling paths in mpt_attach()

On Tue, Feb 23, 2016 at 09:00:12AM -0500, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@...hat.com>
> 
> mpt_attach() was not checking for the failure to create fw_event_q.
> Also, iounmap() was not being called in all error cases after ioremap()
> had been called by mpt_mapresources().
> 
> Reported-by: Insu Yun <wuninsu@...il.com>
> Reviewed-by: Tomas Henzl <thenzl@...hat.com>
> Signed-off-by: Ewan D. Milne <emilne@...hat.com>

Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850