linux-kernel - Re: [PATCH v2] lib/bug.c: use common WARN helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160223103832.5406c5f7@gandalf.local.home>
Date:	Tue, 23 Feb 2016 10:38:32 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Josh Poimboeuf <jpoimboe@...hat.com>, linux-kernel@...r.kernel.org,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Prarit Bhargava <prarit@...hat.com>,
	Chunyu Hu <chuhu@...hat.com>
Subject: Re: [PATCH v2] lib/bug.c: use common WARN helper


Andrew,

Would you like to take this patch?

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


On Tue, 23 Feb 2016 09:27:40 -0600
Josh Poimboeuf <jpoimboe@...hat.com> wrote:

> The traceoff_on_warning option doesn't have any effect on s390, powerpc,
> arm64, parisc, and sh because there are two different types of WARN
> implementations:
> 
> 1) The above mentioned architectures treat WARN() as a special case of a
>    BUG() exception.  They handle warnings in report_bug() in lib/bug.c.
> 
> 2) All other architectures just call warn_slowpath_*() directly.  Their
>    warnings are handled in warn_slowpath_common() in kernel/panic.c.
> 
> Support traceoff_on_warning on all architectures and prevent any future
> divergence by using a single common function to emit the warning.
> 
> Also remove the '()' from '%pS()', because the parentheses look funky:
> 
>   [   45.607629] WARNING: at /root/warn_mod/warn_mod.c:17 .init_dummy+0x20/0x40 [warn_mod]()
> 
> Reported-by: Chunyu Hu <chuhu@...hat.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
> Acked-by: Heiko Carstens <heiko.carstens@...ibm.com>
> Acked-and-tested-by: Prarit Bhargava <prarit@...hat.com>
> ---