linux-kernel - Re: [PATCH v1] serial: mctrl_gpio: Add missing module license

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGkQfmMRXYZmE=jkfLPiDisjySRUiPdJhanQjh5+ej1=pU_nAQ@mail.gmail.com>
Date:	Tue, 23 Feb 2016 17:05:55 +0100
From:	Romain Izard <romain.izard.pro@...il.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] serial: mctrl_gpio: Add missing module license

2016-02-23 16:21 GMT+01:00 Fabio Estevam <festevam@...il.com>:
> On Tue, Feb 23, 2016 at 11:54 AM, Romain Izard
> <romain.izard.pro@...il.com> wrote:
>> As the mctrl_gpio driver can be built as a module, it needs to have its
>> license specified with MODULE_LICENSE. Otherwise, it cannot access
>> required symbols exported through EXPORT_SYMBOL_GPL.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@...il.com>
>> ---
>>  drivers/tty/serial/serial_mctrl_gpio.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
>> index 226ad23b136c..02147361eaa9 100644
>> --- a/drivers/tty/serial/serial_mctrl_gpio.c
>> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
>> @@ -20,6 +20,7 @@
>>  #include <linux/gpio/consumer.h>
>>  #include <linux/termios.h>
>>  #include <linux/serial_core.h>
>> +#include <linux/module.h>
>>
>>  #include "serial_mctrl_gpio.h"
>>
>> @@ -249,3 +250,5 @@ void mctrl_gpio_disable_ms(struct mctrl_gpios *gpios)
>>         }
>>  }
>>  EXPORT_SYMBOL_GPL(mctrl_gpio_disable_ms);
>> +
>> +MODULE_LICENSE("GPL");
>
> Shouldn't it be "GPL v2" instead to match the licensing text in the
> top of the file?

According to include/linux/module.h, "GPL" means "GNU Public License
v2 or later",
which is the license text in the file header.

-- 
Romain Izard