linux-kernel - Re: [PATCH] [media] tvp5150: remove signal generator as input from the DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3469550.VVKtG3tqH6@avalon>
Date:	Tue, 23 Feb 2016 18:16:11 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	devicetree@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] [media] tvp5150: remove signal generator as input from the DT binding

Hi Javier,

On Tuesday 23 February 2016 13:09:58 Javier Martinez Canillas wrote:
> The chip internal signal generator was modelled as an input connector
> and represented as a media entity but isn't really a connector so the
> driver was changed to use the V4L2_CID_TEST_PATTERN control instead.
> 
> Remove the signal generator input from the list of connectors in the
> tvp5150 DT binding document as well since isn't a connector anymore.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> Hello,
> 
> I think is OK to change this DT binding because is only in the media tree
> for now and not in mainline yet and also is expected to change more since
> there are still discussions about how input connectors will be supported
> by the Media Controller framework in the media subsystem.

I think that's fine, yes

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

I haven't noticed the patch that introduced this early enough I'm afraid, and 
I think we still have issues with those bindings.

The tvp5150 node should *not* contain connector subnodes, the connectors nodes 
should use the bindings defined in 
Documentation/devicetree/bindings/display/connector/ and be linked to the 
tvp5150 node using the OF graph bindings (ports and endpoints).

Do you think you could fix that ?

>  Documentation/devicetree/bindings/media/i2c/tvp5150.txt | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
> b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt index
> daa20e43a8e3..d13f8b8e235d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/tvp5150.txt
> @@ -30,9 +30,6 @@ The possible values for the "input" property are:
>  	1: Composite1
>  	2: S-Video
> 
> -and on a tvp5150am1 and tvp5151 there is another:
> -	4: Signal generator
> -
>  The list of valid input connectors are defined in
> dt-bindings/media/tvp5150.h header file and can be included by device tree
> source files.

-- 
Regards,

Laurent Pinchart